HJ-131 Delete monitors before deleting integration #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5478/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | erosselli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
erosselli
commented
Nov 11, 2024
Comment on lines
-193
to
-194
| @pytest.fixture | ||
| def create_monitor_config(self, db: Session, connection_config: ConnectionConfig): |
There was a problem hiding this comment.
moved this fixture to the new detection_discovery_fixtures.py file I created and just renamed it to monitor_config, to be more consistent with our existing fixture names
Comment on lines
+25
to
+27
| if TYPE_CHECKING: | ||
| from fides.api.models.detection_discovery import MonitorConfig | ||
|
|
There was a problem hiding this comment.
this is so mypy doesn't complain about not recognizing the MonitorConfig model. The if TYPE_CHECKING is needed to avoid a circular import
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5478 +/- ##
==========================================
- Coverage 85.20% 85.20% -0.01%
==========================================
Files 386 386
Lines 24234 24242 +8
Branches 2640 2642 +2
==========================================
+ Hits 20649 20655 +6
- Misses 3032 3033 +1
- Partials 553 554 +1 ☔ View full report in Codecov by Sentry. |
thingscouldbeworse
approved these changes
Nov 12, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | erosselli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-131
Description Of Changes
Before, trying to delete an integration (i.e
ConnectionConfig) that had a related monitor (i.eMonitorConfig) would throw a 500 error. Intended behavior is to cascade the deletion so that all monitors associated to the givenConnectionConfigare deleted.Code Changes
ConnectionConfigmodel to explicitly define itsmonitorsreference, and updated the class'deletemethod to iterate over its relatedMonitorConfigs and delete them as welldetection_discovery_fixtures.pyfile to organize D&D fixtures in one single placeSteps to Confirm
Delete integrationPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works