-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Experience Config docs #5405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7e25e9c
to
f7027bc
Compare
fides
|
Project |
fides
|
Branch Review |
refs/pull/5405/merge
|
Run status |
|
Run duration | 00m 38s |
Commit |
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
f7027bc
to
6c4a041
Compare
Kelsey-Ethyca
approved these changes
Oct 24, 2024
Kelsey-Ethyca
added a commit
that referenced
this pull request
Oct 24, 2024
Co-authored-by: Kelsey Thomas <101993653+Kelsey-Ethyca@users.noreply.github.com>
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 38s |
Commit |
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-14
Description Of Changes
Add new documentation for
Fides.experience.experience_config
object.Customers are already relying on these properties for some of their own, client-side logic. As such, we want to carve out a defined set of documented fields on the
Fides.experience
object that customers can rely on that won’t be broken in future updates.As a final step we should run
npm run docs:import
in ourfidesdocs
project to import these docs into the FidesJS SDK Reference section.Pre-Merge Checklist
CHANGELOG.md