Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-16 SSO-Modal-Unexpected-Saves #5365

Merged
merged 2 commits into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ The types of changes are:
- Updating the hash migration status check query to use the available indexes [#5336](https://github.com/ethyca/fides/pull/5336)
- Fixed column resize jank on all tables in Admin UI [#5340](https://github.com/ethyca/fides/pull/5340)
- Better handling of empty storage secrets in aws_util [#5347](https://github.com/ethyca/fides/pull/5347)
- Fix SSO Provider form saving when clicking the cancel button with a fully filled form [#5365](https://github.com/ethyca/fides/pull/5365)


## [2.46.2](https://github.com/ethyca/fides/compare/2.46.1...2.46.2)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ const SSOProviderForm = ({
{values.provider === "custom" && renderCustomProviderExtraFields()}
<Box textAlign="right">
<Button
htmlType="submit"
htmlType="button"
data-testid="cancel-btn"
className="mr-3"
onClick={onClose}
Expand Down
Loading