PROD-2839 Better handling of empty storage secrets in aws_util

[adamsachs]

Closes PROD-2839

Description Of Changes

Added better handling for an empty storage secrets dictionary in the get_aws_session method.

Steps to Confirm

• Add the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env variables to your .env file (creds in 1pass sandboxProgrammaticUserS3)
• Run fides, the admin UI, and the privacy center
• Go to http://localhost:3000/privacy-requests/configure/storage and configure the storage as shown in the image below
• Click Save
• Go to the Privacy Center and submit an access request
• Privacy request should complete successfully

Before, this would raise an AttributeError: 'NoneType' object has no attribute 'get' , now you should be able to submit a privacy request and have results sent to the S3 bucket.

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
  • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated
• If there are any database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 8, 2024 11:13pm

[cypress]

fides    Run #10359

Run Properties:   Passed #10359  •  d9aae8f722 ℹ️: Merge 977bba69709383d1a2dea317ff309d856b30eaeb into b54090bc5f46b0e26549c3dbda94...

Project	fides
Run status	Passed #10359
Run duration	00m 38s
Commit	d9aae8f722 ℹ️: Merge 977bba69709383d1a2dea317ff309d856b30eaeb into b54090bc5f46b0e26549c3dbda94...
Committer	Adam Sachs
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	4
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (b54090b) to head (977bba6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5347   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files         378      378           
  Lines       23994    23996    +2     
  Branches     3218     3219    +1     
=======================================
+ Hits        20472    20474    +2     
  Misses       2932     2932           
  Partials      590      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andres-torres-marroquin]

Checked this manually, works perfectly!

[cypress]

fides    Run #10363

Run Properties:   Passed #10363  •  c294fb532a: PROD-2839 Better handling of empty storage secrets in aws_util (#5347)

Project	fides
Run status	Passed #10363
Run duration	00m 40s
Commit	c294fb532a: PROD-2839 Better handling of empty storage secrets in aws_util (#5347)
Committer	Adam Sachs
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	4
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.