-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gzip Middleware #5225
Add Gzip Middleware #5225
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
Project |
fides
|
Branch Review |
refs/pull/5225/merge
|
Run status |
|
Run duration | 00m 35s |
Commit |
|
Committer | Dawn Pattison |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5225 +/- ##
==========================================
- Coverage 86.41% 86.40% -0.01%
==========================================
Files 362 362
Lines 22763 22765 +2
Branches 3056 3056
==========================================
+ Hits 19670 19671 +1
Misses 2537 2537
- Partials 556 557 +1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice add!
Does this mean for any API req, we can add the "Accept-Encoding": "gzip"
header to get the gzipped resp? Will we need to do this as a follow-up on the FE?
Update changelog
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 36s |
Commit |
|
Committer | Dawn Pattison |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Partially Closes #2604
Description Of Changes
Add Gzip middleware https://fastapi.tiangolo.com/advanced/middleware/#gzipmiddleware specially for compressing responses in Fidesplus Experience Translations.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works