Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gzip Middleware #5225

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Aug 22, 2024

Partially Closes #2604

Description Of Changes

Add Gzip middleware https://fastapi.tiangolo.com/advanced/middleware/#gzipmiddleware specially for compressing responses in Fidesplus Experience Translations.

Code Changes

  • Adds Gzip middleware

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 4:34pm

Copy link

cypress bot commented Aug 22, 2024

fides    Run #9627

Run Properties:  status check passed Passed #9627  •  git commit a72e6814ac ℹ️: Merge 38f38580f897d841c628edd6b88c1df5d88c80b5 into 8457ae655d0c0ad81ced6a926ba9...
Project fides
Branch Review refs/pull/5225/merge
Run status status check passed Passed #9627
Run duration 00m 35s
Commit git commit a72e6814ac ℹ️: Merge 38f38580f897d841c628edd6b88c1df5d88c80b5 into 8457ae655d0c0ad81ced6a926ba9...
Committer Dawn Pattison
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (8457ae6) to head (38f3858).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5225      +/-   ##
==========================================
- Coverage   86.41%   86.40%   -0.01%     
==========================================
  Files         362      362              
  Lines       22763    22765       +2     
  Branches     3056     3056              
==========================================
+ Hits        19670    19671       +1     
  Misses       2537     2537              
- Partials      556      557       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pattisdr pattisdr marked this pull request as ready for review August 22, 2024 21:36
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add!

Does this mean for any API req, we can add the "Accept-Encoding": "gzip" header to get the gzipped resp? Will we need to do this as a follow-up on the FE?

src/fides/api/app_setup.py Show resolved Hide resolved
Update changelog
@pattisdr pattisdr merged commit 697ea7c into main Aug 23, 2024
39 checks passed
@pattisdr pattisdr deleted the PROD-2604_optimize_tcf_privacy_experience branch August 23, 2024 18:14
Copy link

cypress bot commented Aug 23, 2024

fides    Run #9629

Run Properties:  status check passed Passed #9629  •  git commit 697ea7c074: Add Gzip Middleware (#5225)
Project fides
Branch Review main
Run status status check passed Passed #9629
Run duration 00m 36s
Commit git commit 697ea7c074: Add Gzip Middleware (#5225)
Committer Dawn Pattison
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression Tests on System and Taxonomy UI screens - Custom Metadata
2 participants