Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text replacement pattern for Vendor Count #5223

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Aug 21, 2024

Description Of Changes

Updates work done in #5210 and #5217 to now use __VENDOR_COUNT_LINK__ instead. This will align better with other backend templates and avoid ESLint complaints about using the ${...} format for non-template strings as well as potential conflicts with email templates using the {{ }} format

Code Changes

  • replaces {{ VENDOR_COUNT_LINK }} support with __VENDOR_COUNT_LINK__ instead.

Steps to Confirm

  • In Admin UI, update the TCF experience English string to include "VENDOR_COUNT_LINK" (eg. "We, and our VENDOR_COUNT_LINK vendors, use cookies...)
  • Open demo page using a TCF experience (eg. http://localhost:3001/fides-js-demo.html?geolocation=eea)
  • Note that the banner and modal descriptions have been modified to include the count/button.
  • Note that the text "vendors page." is not linked.

Pre-Merge Checklist

  • All CI Pipelines Succeeded

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Aug 21, 2024 5:01pm

Copy link

cypress bot commented Aug 21, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit a6b8431245 ℹ️
Started Aug 21, 2024 5:13 PM
Ended Aug 21, 2024 5:14 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@gilluminate gilluminate merged commit a486666 into main Aug 21, 2024
13 checks passed
@gilluminate gilluminate deleted the update-template-pattern-2 branch August 21, 2024 17:14
Copy link

cypress bot commented Aug 21, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit a486666
Started Aug 21, 2024 5:26 PM
Ended Aug 21, 2024 5:27 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants