Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toast on muting/ignoring a resource in D&D tables #5214

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Aug 19, 2024

Closes PROD-2544

Description Of Changes

Adds a success toast on muting/ignoring a resource in the detection actions and discovery actions.

Screenshot 2024-08-19 at 16 35 49

Screenshot 2024-08-19 at 16 36 04

Steps to Confirm

Should see toast on muting resources from either detection table or discovery table.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 7:01pm

Copy link

cypress bot commented Aug 19, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 2f7198adb8 ℹ️
Started Aug 20, 2024 7:13 PM
Ended Aug 20, 2024 7:14 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jpople jpople requested a review from lucanovera August 20, 2024 16:18
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toasts looks good. Default timing seems about right. Toast stacks. Approved. You're just missing the changelog update.

@jpople jpople merged commit 3ad4808 into main Aug 20, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2544/new-dnd-toasts branch August 20, 2024 19:23
Copy link

cypress bot commented Aug 20, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 3ad4808
Started Aug 20, 2024 7:34 PM
Ended Aug 20, 2024 7:35 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants