Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy on new integrations UI #5007

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jun 19, 2024

Closes PROD-2185

Description Of Changes

Adds explanatory copy to project selection modal and changes copy on discovery monitor table.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:20pm

Copy link

cypress bot commented Jun 19, 2024

Passing run #8443 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d6da7fb into c34d3c7...
Project: fides Commit: a1b45aba42 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jun 20, 2024 5:30 PM Ended: Jun 20, 2024 5:30 PM

Review all test suite changes for PR #5007 ↗︎

Copy link

@jack-gale-ethyca jack-gale-ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeremy sent screenshots which look good to me!

@jpople
Copy link
Contributor Author

jpople commented Jun 20, 2024

Updating to add DynamoDB and S3 copy as shown:

Screenshot 2024-06-20 at 13 16 08
Screenshot 2024-06-20 at 13 17 04
Screenshot 2024-06-20 at 13 17 10

@jpople jpople merged commit 2855b98 into main Jun 20, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2185/ddnd-copy-updates branch June 20, 2024 20:02
jpople added a commit that referenced this pull request Jun 20, 2024
Copy link

cypress bot commented Jun 20, 2024

Passing run #8455 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Update copy on new integrations UI (#5007)
Project: fides Commit: 2855b98a11
Status: Passed Duration: 00:36 💡
Started: Jun 20, 2024 8:14 PM Ended: Jun 20, 2024 8:14 PM

Review all test suite changes for PR #5007 ↗︎

adamsachs pushed a commit that referenced this pull request Jun 21, 2024
@cypress cypress bot mentioned this pull request Jun 21, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants