Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to gpc label and fix wrapping in firefox #4600

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

Closes # https://ethyca.atlassian.net/browse/PROD-1601

Description Of Changes

Add padding to gpc label and fix wrapping in firefox

Code Changes

  • replace text-wrap with white-space since nowrap doesn't work on firefox
  • add padding between gpc label and on/off toggle in the consent modal

Steps to Confirm

  • add systems to the preview env through the consent vendor add flow
  • enable all privacy notices
  • turn on gpc in your browser
  • nav to cookie house sample app
  • verify there is space between gpc label and on/off toggle in the modal
  • verify the "global privacy consent" text and "applied" tag are not wrapped

Pre-Merge Checklist

Screenshot 2024-02-07 at 2 47 12 PM

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 10:23pm

Copy link

cypress bot commented Feb 7, 2024

Passing run #6213 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 7a66b61 into 0135810...
Project: fides Commit: 6b7f8a7fa7 ℹ️
Status: Passed Duration: 00:36 💡
Started: Feb 7, 2024 10:32 PM Ended: Feb 7, 2024 10:33 PM

Review all test suite changes for PR #4600 ↗︎

@Kelsey-Ethyca
Copy link
Contributor Author

checked and tcf tag still looks good
Screenshot 2024-02-07 at 3 20 54 PM

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Any consideration for also padding the left side of the badge? Feel like that looks a little crowded as-is.

@Kelsey-Ethyca
Copy link
Contributor Author

Looks good to me! Any consideration for also padding the left side of the badge? Feel like that looks a little crowded as-is.

I thought it made sense to have "Global privacy control" right next to applied to make sure it was clear what was being applied.

this is what it looks like with a bit more space and the text, badge, and toggle are too evenly space
Screenshot 2024-02-08 at 4 52 20 PM

@Kelsey-Ethyca Kelsey-Ethyca merged commit 3be7c2b into main Feb 8, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-1601-gpc-padding branch February 8, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants