Simon Data Connector #3705
Simon Data Connector #3705
Conversation
we are still missing credentials to test with at this point as far as I am aware
d7a7d55 to
d6f480d
Compare
…-simon-data-connector
Passing run #3353 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
|
@galvana - I think I need some help with secrets here potentially? There also appear to be some existing mypy and pytest errors but I think those are known. Thanks for any help here!! |
There was a problem hiding this comment.
Check out tests/ops/integration_tests/saas/test_surveymonkey_task.py for a reference and let's add an assertion to make sure that the first endpoint in the traversal only returns objects that match our identity email. Same thing for the erasures, let's define our expectation of which collections should be affected by the erasure.
| simon_data_erasure_identity_email: str, | ||
| ) -> Generator: | ||
| # create the data needed for erasure tests here | ||
| yield {} |
There was a problem hiding this comment.
Does Simon Data allow us to submit an erasure request if we don't have any data for the erasure identity email?
There was a problem hiding this comment.
I believe the request succeeded fine, I tested it with an email that shouldn't have existed but will re-verify
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
…-simon-data-connector
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3705 +/- ##
=======================================
Coverage 87.18% 87.18%
=======================================
Files 317 317
Lines 19350 19350
Branches 2485 2485
=======================================
Hits 16870 16870
Misses 2049 2049
Partials 431 431 ☔ View full report in Codecov by Sentry. |
|
closing in favor of #4552 |
Closes #3699
Description Of Changes
Used the saas connector template via
nox🔥Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md