LA-16 SSO-Modal-Unexpected-Saves (#5365)

Co-authored-by: Lucano Vera <lucanovera@ethyca.com>
ethyca · Oct 9, 2024 · f427c67 · f427c67
1 parent 3699023
commit f427c67
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,8 @@ The types of changes are:
 - Updating the hash migration status check query to use the available indexes [#5336](https://github.com/ethyca/fides/pull/5336)
 - Fixed column resize jank on all tables in Admin UI [#5340](https://github.com/ethyca/fides/pull/5340)
 - Better handling of empty storage secrets in aws_util [#5347](https://github.com/ethyca/fides/pull/5347)
+- Fix SSO Provider form saving when clicking the cancel button with a fully filled form [#5365](https://github.com/ethyca/fides/pull/5365)
+
 
 ## [2.46.2](https://github.com/ethyca/fides/compare/2.46.1...2.46.2)
 

diff --git a/clients/admin-ui/src/features/openid-authentication/SSOProviderForm.tsx b/clients/admin-ui/src/features/openid-authentication/SSOProviderForm.tsx
@@ -206,7 +206,7 @@ const SSOProviderForm = ({
             {values.provider === "custom" && renderCustomProviderExtraFields()}
             <Box textAlign="right">
               <Button
-                htmlType="submit"
+                htmlType="button"
                 data-testid="cancel-btn"
                 className="mr-3"
                 onClick={onClose}