Apply suggestions from code review

Co-authored-by: Adrian Galvan <adrian@ethyca.com>
ethyca · Nov 4, 2024 · a590590 · a590590
1 parent 37004e7
commit a590590
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,8 +22,7 @@ The types of changes are:
 - Added keepalive settings to the Redshift integration [#5433](https://github.com/ethyca/fides/pull/5433)
 
 ### Changed
-- Add an environment variable that must be true to enable the Access request download feature [#5451](https://github.com/ethyca/fides/pull/5451)
-
+- Added a security setting that must be set to true to enable the access request download feature [#5451](https://github.com/ethyca/fides/pull/5451)
 
 ### Developer Experience
 - Added Carbon Icons to FidesUI [#5416](https://github.com/ethyca/fides/pull/5416)

diff --git a/src/fides/api/api/v1/endpoints/privacy_request_endpoints.py b/src/fides/api/api/v1/endpoints/privacy_request_endpoints.py
@@ -2594,7 +2594,7 @@ def get_access_results_urls(
     """
     if not CONFIG.security.subject_request_download_ui_enabled:
         raise HTTPException(
-            status_code=HTTP_404_NOT_FOUND,
+            status_code=HTTP_403_FORBIDDEN,
             detail="Access results download is disabled.",
         )
     privacy_request: PrivacyRequest = get_privacy_request_or_error(

diff --git a/tests/ops/api/v1/endpoints/test_privacy_request_endpoints.py b/tests/ops/api/v1/endpoints/test_privacy_request_endpoints.py
@@ -8277,4 +8277,4 @@ def test_get_access_results_contributor_but_disabled(
             contributor_user, roles=contributor_user.permissions.roles
         )
         response = api_client.get(url, headers=auth_header)
-        assert response.status_code == 404
+        assert response.status_code == 403