HA-426 - Datahub - Make glossary node to use for Data Categories conf…

…igurable (#5734)
ethyca · Feb 5, 2025 · a42c0ff · a42c0ff
1 parent deef26b
commit a42c0ff
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
 
 ### Changed
 - Added frequency field to DataHubSchema integration config [#5716](https://github.com/ethyca/fides/pull/5716)
+- Added glossary_node field to DataHubSchema integration config [#5734](https://github.com/ethyca/fides/pull/5734)
 - Added initial support for upcoming "headless" CMP experience type [#5731](https://github.com/ethyca/fides/pull/5731)
 
 ### Fixed

diff --git a/src/fides/api/schemas/connection_configuration/connection_secrets_datahub.py b/src/fides/api/schemas/connection_configuration/connection_secrets_datahub.py
@@ -33,6 +33,11 @@ class DatahubSchema(ConnectionConfigSecretsSchema):
         description="The frequency at which the integration should run. Defaults to daily.",
         default=PeriodicIntegrationFrequency.daily,
     )
+    glossary_node: str = Field(
+        title="Glossary Node",
+        description="The glossary node name to use on Datahub for Fides Data Categories. Defaults to FidesDataCategories",
+        default="FidesDataCategories",
+    )
 
     _required_components: ClassVar[List[str]] = ["datahub_server_url", "datahub_token"]
 

diff --git a/tests/ops/api/v1/endpoints/test_connection_config_endpoints.py b/tests/ops/api/v1/endpoints/test_connection_config_endpoints.py
@@ -2036,6 +2036,7 @@ def test_put_datahub_connection_config_secrets(
             "datahub_server_url": "https://datahub.example.com",
             "datahub_token": "test",
             "frequency": "weekly",
+            "glossary_node": "FidesDataCategories",
         }
         assert datahub_connection_config_no_secrets.last_test_timestamp is None
         assert datahub_connection_config_no_secrets.last_test_succeeded is None
@@ -2072,6 +2073,7 @@ def test_put_datahub_connection_config_secrets_default_frequency(
             "datahub_server_url": "https://datahub.example.com",
             "datahub_token": "test",
             "frequency": "daily",
+            "glossary_node": "FidesDataCategories",
         }
         assert datahub_connection_config_no_secrets.last_test_timestamp is None
         assert datahub_connection_config_no_secrets.last_test_succeeded is None