Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #114

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Fix warnings #114

merged 3 commits into from
Oct 12, 2024

Conversation

syntrust
Copy link
Contributor

Fix warnings like

  • Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
    by commenting out the variable names. Leave DecentralizedKV.sol: removeTo(bytes32 _key, address _to) untouched because the documentation of params requires the names.

  • Warning: This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
    by using receive()

  • Some Warning: Contract code size is 26418 bytes and exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on Mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
    by removing unnecessary imports.

@syntrust syntrust requested review from qzhodl and ping-ke October 10, 2024 08:33
@syntrust syntrust requested a review from qzhodl October 11, 2024 10:03
@syntrust syntrust merged commit 648e477 into main Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants