Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label the geth-client that is spun up alongside the builder differently from the other geth clients on the Ethereum nodes #119

Closed
leeederek opened this issue Aug 10, 2023 · 3 comments · Fixed by #347
Assignees
Labels
good first issue Good for newcomers

Comments

@leeederek
Copy link
Contributor

Hey, when I run the eth2-package with full-mev, I expect there to be 2 Geth clients: 1 directly spun up with the MEV-builder, and another regular Geth client as part of an Ethereum full node.

In the output at the end (kurtosis enclave ls), it's not obvious to me as a user which one is which:

============================================== User Services ==============================================
UUID           Name                           Ports                                                  Status
e7f673086384   el-1-geth-lighthouse           engine-rpc: 8551/tcp -> 127.0.0.1:62861                RUNNING
                                              rpc: 8545/tcp -> 127.0.0.1:62863
                                              tcp-discovery: 30303/tcp -> 127.0.0.1:62862
                                              udp-discovery: 30303/udp -> 127.0.0.1:56858
                                              ws: 8546/tcp -> 127.0.0.1:62860
3048d9aafc12   el-2-geth-lighthouse           engine-rpc: 8551/tcp -> 127.0.0.1:62866                RUNNING
                                              rpc: 8545/tcp -> 127.0.0.1:62864
                                              tcp-discovery: 30303/tcp -> 127.0.0.1:62867
                                              udp-discovery: 30303/udp -> 127.0.0.1:62287
                                              ws: 8546/tcp -> 127.0.0.1:62865
@barnabasbusa
Copy link
Contributor

I think this makes sense. We could append builder to the the clients that behave as a builder.

So in this case it would be el-2-geth-lighthouse-builder

@barnabasbusa barnabasbusa added the good first issue Good for newcomers label Oct 16, 2023
@bharath-123
Copy link
Contributor

hey can i pick this up?! I have some free time want to spend some of it contributing to kurtosis! :D

@barnabasbusa
Copy link
Contributor

go for it!!

barnabasbusa added a commit that referenced this issue Nov 21, 2023
Resolves #119

---------

Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants