Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete hardcoded mempools & configurable mempool id #148

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

0xSulpiride
Copy link
Contributor

@0xSulpiride 0xSulpiride commented Feb 8, 2024

Description

  • deleted all hardcoded mempool ids
  • mempool id can be set in config.json using these 2 params: canonicalMempoolId and canonicalMempoolEntryPoint

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride marked this pull request as ready for review February 8, 2024 11:42
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondering if we should also add a constants/defaults for EP and mempoolId which will be used as a fallback in case these values are not provided in the config file?

@0xSulpiride
Copy link
Contributor Author

@ch4r10t33r I'm not sure if this is future-proof, because we would have to change or delete fallback values in case of a change to mempool ids so that adds some maintenance burden on us

@0xSulpiride 0xSulpiride merged commit b398b9f into develop Feb 16, 2024
1 of 3 checks passed
@0xSulpiride 0xSulpiride deleted the configurable-mempool-id branch February 16, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants