Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: EntryPoint v7 support #145

Merged
merged 14 commits into from
Feb 28, 2024
Merged

feat: EntryPoint v7 support #145

merged 14 commits into from
Feb 28, 2024

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Feb 2, 2024 •
edited
Loading

Description

  • added support for EntryPointV7 (eth-infinitism/account-abstraction@82a70f9) - although EP7 is under develop atm, so we might need to revisit it after a while
  • added config params entryPointsV6, entryPointsV7 and entryPointV7Simulation

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title wip: EntryPoint v7 support feat: EntryPoint v7 support Feb 5, 2024
ch4r10t33r
ch4r10t33r requested changes Feb 18, 2024
View reviewed changes
packages/api/src/modules/debug.ts Outdated Show resolved Hide resolved
packages/api/src/modules/debug.ts Outdated Show resolved Hide resolved
packages/executor/src/config.ts Outdated
@@ -73,18 +73,29 @@ export class Config {
}

isEntryPointSupported(entryPoint: string): boolean {
return !!this.config.entryPoints.some(
const ep6 = this.config.entryPointsV6 || [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us remove support for EP 6.0 in the latest version of skandha.

ch4r10t33r
ch4r10t33r approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSulpiride 0xSulpiride merged commit 39f82ec into develop Feb 28, 2024
1 of 2 checks passed
@0xSulpiride 0xSulpiride deleted the epv7 branch February 28, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r