This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Fix data race in TestNetworkID test #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
approved these changes
Jan 15, 2019
zelig
approved these changes
Jan 15, 2019
frncmx
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
lgtm 👍
1st I was surprised we can shutdown the network, i.e., for all nodes: node.Stop() . I thought nodes would drop peers and lose their Kademila table. Then I realized the whole kademlias is populated for the test in a node service.
Smart, simple solution.
|
Maybe you already know :) tip: if the commit message includes |
|
Submitted to upstream ethereum/go-ethereum#18460. |
|
Thank you all for reviews. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes data races described in #1112 issue.