Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: basic conventions #17

Merged
merged 25 commits into from
Dec 3, 2020
Merged

refactor: basic conventions #17

merged 25 commits into from
Dec 3, 2020

Conversation

nugaon
Copy link
Member

@nugaon nugaon commented Dec 3, 2020

Features

  • added eslint rules, prettier and tsconfig to the project,
  • refactor the already existing code by that,
  • created npm run format command for rewrite all ts files in src/** and test/**
  • defined VSCode settings for auto-correcting on save and use Prettier

TODO

  • Redesign GitHub Workflow (browser tests)
  • Change README
  • Webpack integration
  • Replace Karma with Jest
  • Remove Tasegir dependency
  • Browser tests
  • make Jest alias same as in webpack (browser<->node)

vojtechsimetka and others added 24 commits November 7, 2020 03:21
@vojtechsimetka
chore: repository setup
13ed874
@vojtechsimetka
feat: adds tag API wrapper
1ab7715
@vojtechsimetka
feat: adds file API wrapper
2450765
@vojtechsimetka
docs: adds docs for file and tags
5f4033b
@nugaon
fix: add .gitignore
5cc6afd
@nugaon
style: create eslint rules, prettier config and ts config. Defined vs…
9573449 
…code config
@nugaon
refactor: rewrite code according to the formatter rules
b82d6b9
@vojtechsimetka
fix: add .gitignore
46181a7
@nugaon
style: remove semicolons and its rule from eslint
d2a1bde
@nugaon
Merge branch 'feat/basicFunctionality' of github.com:ethersphere/bee-…
ff51de6 
…js into refactor/basicConventions
@nugaon
chore: own tsconfig, eslint and testing configurations
7e5defe
@nugaon
refactor: remove unnecessary browser distinction on data initialization
0f1417f
@nugaon
chore: 💥 Replace Mocha/Karma with Jest
bfed52d
@nugaon
test: ♻️ refactor test code according to Jest
eb89f16
@nugaon
fix: 🐛 hack in order to send custom HTTP headers by axios within jsdom
facd42d
@nugaon
ci: 🔧 change github workflows according to the config changes
9077135
@nugaon
style: 🚨 remove remaining semicolons
90396e2
@nugaon
chore: 🔧 refactor dependecies, update eslint
39b4dcc
@nugaon
ci: 🐛 typeo at lint-check
25720a4
@nugaon
docs: 📝 Ammend doc according to the new env
229cd7f
@nugaon
refactor: ➖ Remove unused config files
148d62c
@nugaon
test: 🔧 run dom/node tests separately from npm
f9497f8
@nugaon
refactor: 🔧 remove suggested scripts from npm
7f37562
@nugaon
Merge branch 'master' into refactor/basicConventions
04319ba
vojtechsimetka
vojtechsimetka approved these changes Dec 3, 2020
View reviewed changes
.gitignore
@@ -1,7 +1,4 @@
lib
types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we now be packing types directly and not generating them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes it's necessary, for example when u'll write ur own Jest matchers.

@nugaon nugaon merged commit f1123c5 into master Dec 3, 2020
@vojtechsimetka vojtechsimetka deleted the refactor/basicConventions branch December 3, 2020 20:39
This was referenced Dec 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechsimetka vojtechsimetka vojtechsimetka approved these changes

@agazso agazso Awaiting requested review from agazso

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nugaon @vojtechsimetka