Error: invalid object key - from - using Ledger Signer

[andrewpaulicek]

Hi,

I have noticed there is a similar issue to #862 when using the LedgerSigner.

"@ethersproject/hardware-wallets": "^5.0.1",
"ethers": "^5.0.4",

The fix that worked out for me locally was to add from to allowedTransactionKeys array in @ethersproject/transaction.
https://github.com/ethers-io/ethers.js/blob/master/packages/transactions/src.ts/index.ts#L72

[ricmoo]

Can you provide a code snippet? :)

[andrewpaulicek]

Hi,
sure thing.

const provider = new ethers.providers.JsonRpcProvider(rpcUrl);
const signer = new LedgerSigner(provider, 'hid', derivationPath ?? `m/44'/60'/0'/0/0`);
const feedContract = new ethers.Contract(feed.contractAddress.toString(), fluxAggregatorAbi, signer);
var res = await feedContract.withdrawPayment(oracleAddress, withdrawTo, withdrawableAmount, txOptions);

Our use case is calling a withdrawPayment function on the smart contract, but you won't be able to test it with this particular call / ABI :(.

[dhadrien]

I had the exact same issue, it seems sendTransaction does not work while signTransaction works.

Indeed I broadcasted the rawTransaction from a signTransaction and the tx was working as intended, however using the sendTransaction I got the following error:

UnhandledPromiseRejectionWarning: Error: invalid object key - from (argument="transaction:from"

The code creating the error

    const signer = new LedgerSigner(provider, 'hid', "44'/60'/0'/0");
    const addr = await signer.getAddress();
    const chaindId = await signer.getChainId();
    const nonce = await signer.getTransactionCount();
    txData.chainId = chaindId;
    // txData.from = addr;
    txData.nonce = nonce;
    const sentTransaction = await signer.sendTransaction(txData);

the code working as intended:

    const signer = new LedgerSigner(provider, 'hid', "44'/60'/0'/0");
    const addr = await signer.getAddress();
    const chaindId = await signer.getChainId();
    const nonce = await signer.getTransactionCount();
    txData.chainId = chaindId;
    // txData.from = addr;
    txData.nonce = nonce;
    const signedTransaction = await signer.signTransaction(txData);

[dhadrien]

Oh, and the chainId was not automatically added by the signer, might be related.

[dhadrien]

Hey @ricmoo :) No pressure, but was wondering: should I do a hot fix locally are do you plan to release the bug fix soon?

Thanks!!

[ricmoo]

I’m trying to burn through the backlog right now, but this might be a week or two before I get this far back. If you can hotfix it for now, go for it. I’ll comment this ticket (which will notify you) once I get to it. :)

[ricmoo]

(I think this should be an easy fix, so I might take a look at this shortly actually; I’m having issues with my mocha reporter in the browser, and it’s easy to sneak in a few easy tasks with updates to the test case stuff ;))

[dhadrien]

that would be amazing <3 thanks for the quick reply anyway!

You rock man

[ricmoo]

This should be fixed now, please try it if you have any issues let me know. :)

Thanks! :)