-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add ParamType into the ABI typing #721
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
Comments
This has been published in |
I haven't heard any more complaints and a few people have updated and found the problem is fixed, so I'm going to close this now. Please feel free to re-open if you continue to have issues. Thanks! :) |
Thanks @ricmoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Verified to be an issue.
fixed/complete
This Bug is fixed or Enhancement is complete and published.
This seems to have broken a few things (See: dethcrypto/TypeChain#206).
I will add the
ParamType
back into thecontractInterface
constructor and related function (for example, 6da5c53#diff-a3e6713bb3c02c967405706be5ce2163L367).Anyone passing in a ParamType will crash, since this object is verified at runtime, but since it has been like that for ages, it won't cause any problems that weren't already present. But it seems the ParamType was allowing some things that shared its "shape" work, in the case of JSON objects.
This will only be changed in v4 (v5 is happy with the correct signature ;)).
The text was updated successfully, but these errors were encountered: