Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add ParamType into the ABI typing #721

Closed
ricmoo opened this issue Jan 28, 2020 · 3 comments
Closed

Re-add ParamType into the ABI typing #721

ricmoo opened this issue Jan 28, 2020 · 3 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Jan 28, 2020

This seems to have broken a few things (See: dethcrypto/TypeChain#206).

I will add the ParamType back into the contractInterface constructor and related function (for example, 6da5c53#diff-a3e6713bb3c02c967405706be5ce2163L367).

Anyone passing in a ParamType will crash, since this object is verified at runtime, but since it has been like that for ages, it won't cause any problems that weren't already present. But it seems the ParamType was allowing some things that shared its "shape" work, in the case of JSON objects.

This will only be changed in v4 (v5 is happy with the correct signature ;)).

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. labels Jan 28, 2020
@ricmoo ricmoo added bug Verified to be an issue. and removed enhancement New feature or improvement. labels Jan 29, 2020
ricmoo added a commit that referenced this issue Jan 30, 2020
@ricmoo
Copy link
Member Author

ricmoo commented Jan 30, 2020

This has been published in 4.0.44. Please try it out and let me know if it works for you.

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jan 31, 2020
@ricmoo
Copy link
Member Author

ricmoo commented Feb 2, 2020

I haven't heard any more complaints and a few people have updated and found the problem is fixed, so I'm going to close this now. Please feel free to re-open if you continue to have issues.

Thanks! :)

@ricmoo ricmoo closed this as completed Feb 2, 2020
@HenryNguyen5
Copy link

Thanks @ricmoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants