isHexString function not exported by library

[bojan96]

isHexString function is not exported by ethers.js
It seems that problem is located in src.ts/utils/index.ts

index.ts:

export {
    AbiCoder,
    defaultAbiCoder,
    formatSignature,
    formatParamType,
    parseSignature,
    parseParamType,

    RLP,

    fetchJson,
    getNetwork,

    checkProperties,
    deepCopy,
    defineReadOnly,
    resolveProperties,
    shallowCopy,

    arrayify,

    concat,
    padZeros,
    stripZeros,

    HDNode,
    SigningKey,

    Interface,

    base64,

    BigNumber,
    bigNumberify,
// isHexString MISSING
    hexlify,
    hexStripZeros,
    hexZeroPad,
    hexDataLength,
    hexDataSlice,

    toUtf8Bytes,
    toUtf8String,

    formatBytes32String,
    parseBytes32String,

    hashMessage,
    namehash,
    id,

    getAddress,
    getIcapAddress,
    getContractAddress,

    formatEther,
    parseEther,

    formatUnits,
    parseUnits,

    commify,

    keccak256,
    sha256,

    randomBytes,

    solidityPack,
    solidityKeccak256,
    soliditySha256,

    splitSignature,
    joinSignature,

    parseTransaction,
    populateTransaction,
    serializeTransaction,

    getJsonWalletAddress,

    computeAddress,
    computePublicKey,
    recoverAddress,
    recoverPublicKey,
    verifyMessage,


    ////////////////////////
    // Enums

    SupportedAlgorithms,
    UnicodeNormalizationForm,


    ////////////////////////
    // Types

    CoerceFunc,
    EventFragment,
    FunctionFragment,
    ParamType,

    BigNumberish,

    Arrayish,
    Hexable,
    Signature,

    Indexed,

    DeployDescription,
    EventDescription,
    FunctionDescription,
    LogDescription,
    TransactionDescription,

    Network,
    Networkish,

    Transaction,
    UnsignedTransaction,

    ConnectionInfo,
    OnceBlockable,
    PollOptions,

    EncryptOptions,
    ProgressCallback,

    Wordlist,

}

[dhl]

You can access isHexString by importing it directly from bytes.ts.

TypeScript

import { isHexString } from 'ethers/utils/bytes';

Node

const { isHexString } = require('ethers/utils/bytes');

Not quite sure what @ricmoo has in mind, but perhaps he did not want to re-export every exportable function in bytes.ts, because otherwise, import from bytes could have been replaced with

export * from 'bytes';

[ricmoo]

I do recall not exporting it on purpose, but I can't think of a good reason... I'll take a look to see what else is not being exported too. It is probably useful to export.

[ricmoo]

This function is now exported. There are several places in the code that currently use hexDataLength, which will likely be updated in the future to use the second optional parameter, which lets the check also include a test for length (in bytes; i.e. the hex string must be even length).

These functions will probably be juggled around a bit in v5. Just a heads up. :)

Thanks! :)