Cannot read property 'confirmations' of null when calling provider.waitForTransaction

[Dvisacker]

I just updated to 4.0.11 and when making the following call:

let receipt = await signer.provider.waitForTransaction(tx.hash)

I get the following error:

Cannot read property 'confirmations' of null

Which seems to be related to the code below:

    BaseProvider.prototype.waitForTransaction = function (transactionHash, confirmations) {
        var _this = this;
        if (confirmations == null) {
            confirmations = 1;
        }
        return web_1.poll(function () {
            return _this.getTransactionReceipt(transactionHash).then(function (receipt) {
                if (receipt == null && confirmations !== 0) {
                    if (receipt.confirmations < confirmations) {
                        return undefined;
                    }
                }
                return receipt;
            });
        }, { onceBlock: this });
    };

It should be receipt != null or something i suppose ?

[ricmoo]

Ack! You are right! That's almost the solution, I was trying to simplify the if condition too much and got De Morgan's Law a little messed up in my head.

I'm fixing it right now. :)

[ricmoo]

I've posted it to version 4.0.12, if you could try it out and make sure it solved the problem?

[ricmoo]

I'm going to close this now, but if it is still a problem, please re-open it.

Thanks! :)

[lastmjs]

I still am getting this error. I'm not calling waitForTransaction on a signer, but on my provider directly. I'm using 4.0.27 of the library.

[PaulRBerg]

Also just happened to me using the beta version 5.0.0-beta.162. All I did was to follow the docs:

// The operation is NOT complete yet; we must wait until it is mined
await tx.wait();

[PaulRBerg]

Update: also happens with 4.0.40.

[PaulRBerg]

Okay so the issue is on this line in v4:

ethers.js/src.ts/providers/base-provider.ts

Line 792 in 4ac0843

if (receipt.confirmations < confirmations) { return; }

And in v5:

ethers.js/packages/providers/src.ts/base-provider.ts

Line 458 in 9c78c7f

if (receipt.confirmations < confirmations) { return; }

You need to check that receipt is defined and only then access "confirmations". I patched this on my fork, for both v4 and v5, but I get this error now:

no matching event (argument="topichash", value="0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef", version=abi/5.0.0-beta.142)

[hilmarx]

@PaulRBerg did you manage to find a solution for the no matching event bug? Stumbled across the same one when trying to wait for transactions to be mined using Wallet Connect in v5.

[hilmarx]

@ricmoo the error code I get when trying to wait for a transaction that was sent via Argents Wallet Connect integration:

Error: no matching event (argument="topichash", value="0x7d2476ab50663f025cff0be85655bcf355f62768615c0c478f3cd5293f807365", code=INVALID_ARGUMENT, version=abi/5.0.0-beta.144)
    at Logger.makeError (ethers.umd.js:3579)
    at Logger.throwError (ethers.umd.js:3588)
    at Logger.throwArgumentError (ethers.umd.js:3591)
    at Interface.getEvent (ethers.umd.js:8114)
    at Interface.parseLog (ethers.umd.js:8340)
    at ethers.umd.js:9004
    at Array.map (<anonymous>)
    at ethers.umd.js:9002
    at async Object.btnFunc (TransactionCard.tsx:796)

It seems to work fine with Gnosis Safe Wallet Connect integrations though, weird.