Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from Buffer constructor #265

Closed
gabrielschulhof opened this issue Aug 28, 2018 · 2 comments
Closed

Move away from Buffer constructor #265

gabrielschulhof opened this issue Aug 28, 2018 · 2 comments
Assignees
@ricmoo
Labels
enhancement New feature or improvement.

Comments

@gabrielschulhof
Copy link

new Buffer(...) is deprecated and unsafe. Is it possible to replace it with Buffer.from(...) in these places?
@gabrielschulhof gabrielschulhof mentioned this issue Aug 28, 2018
Closed
4 tasks
@ricmoo ricmoo self-assigned this Aug 28, 2018
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. v4.0 labels Aug 28, 2018
@ricmoo
Copy link
Member

ricmoo commented Aug 28, 2018

Thanks! I will update the v4 branch tomorrow. :)

ricmoo added a commit that referenced this issue Sep 6, 2018
@ricmoo
Change Buffer constructor to safer operations (#265).
7aebe53
@ricmoo
Copy link
Member

ricmoo commented Sep 10, 2018

I've made these changes in the latest v4 branch.

Thanks!

@ricmoo ricmoo closed this as completed Sep 10, 2018
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
enhancement New feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @gabrielschulhof