Event Decoder stores numbers oddly.

[MicahZoltu]

When decoding an event like Foo(uint256 a), I end up with an object like:

{ /*...*/, values: { a: { _hex: '0x5' } } }

I would have expected a BigNumber here, or barring that a hex encoded string. _ prefixed property names are usually internal, so I am hesitant to write code that relies or reading that. Also, non-number values are stored without the inner-most object, so just { b: '0xabcd1234' }, which makes number values odd.

After a significant amount of digging I found the issue is in the way it "freezes" the values key. It does JSON.stringify then JSON.parse on it, which results in stripping the prototype from all of the methods and leaving only the _hex internal variable of the original BigNumber object.

[ricmoo]

That is certainly a bug. Can you provide a quick snippet? Are you on the v4 branch? I recall adding a fix for that, but I must have missed some place.

[ricmoo]

Oh! Looking at the code and your example, I understand the bug. I’ll get a fix out soon. Thanks!

[MicahZoltu]

I'm experiencing this on the 4.0.0-beta.12, and the linked code is in typescript branch.

[ricmoo]

Yeah. I'm going to make a proper copyDeep that supports an immutability flag and replace defineFrozen with defineReadOnly(copyDeep(o)). I'll also see about getting rid of jsonCopy and using the new copyDeep.

The problem is with nested structures, like a tuple or array which contains BigNumbers. I felt the cold chill the second I read the _hex in your issue, and realized the error of my ways once I looked at the code... :)

Thanks!

[ricmoo]

This should be fixed in 4.0.0-beta.13.

Closing for now, but if you continue experiencing any issues, please feel free to re-open. :)