Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for bool type in utils.solidityKeccak256 #113

Closed
adamdossa opened this issue Feb 4, 2018 · 3 comments
Closed

Support for bool type in utils.solidityKeccak256 #113

adamdossa opened this issue Feb 4, 2018 · 3 comments
Assignees
@ricmoo
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@adamdossa
Copy link

Looks like the underlying _pack function does not support the Solidity bool type - this would be nice to add.
@ricmoo ricmoo self-assigned this Feb 4, 2018
@ricmoo ricmoo added the bug Verified to be an issue. label Feb 4, 2018
@ricmoo
Copy link
Member

ricmoo commented Feb 4, 2018

I’m not at a computer right now, but a quick look at the solidity utility function looks like you are right. This is a bug and I will address is ASAP. Also, I need to check the procedural test cases, because they must be missing bool too.

Thanks!

ricmoo added a commit that referenced this issue Feb 4, 2018
@ricmoo
Added bool support to Solidity-style hash functions (#113).
6ade579
@ricmoo
Copy link
Member

ricmoo commented Feb 4, 2018

Travis CI is running against the new test cases now. Once they pass, I will publish to npm.

@ricmoo
Copy link
Member

ricmoo commented Feb 4, 2018

Fixed in ethers@2.2.5.

Thanks again! :)

@ricmoo ricmoo closed this as completed Feb 4, 2018
@ricmoo ricmoo added the fixed/complete This Bug is fixed or Enhancement is complete and published. label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @adamdossa