Better errors for un-configured ENS names

[zemse]

The documentation at https://docs.ethers.io/v5/api/providers/provider/#Provider--ens-methods mentions that:

In the ethers API, nearly anywhere that accepts an address, an ENS name may be used instead, which can simplify code and make reading and debugging much simpler.

Some examples I tried it on: new Contract(abi, address), provider.getBalance(address). And it works there, so awesome!

But when I did with a contract method:

> erc20ContractInstance.balanceOf('some.ens.name')

Error: invalid address (argument="address", value=null, code=INVALID_ARGUMENT, version=
address/5.0.2) (argument="_owner", value=null, code=INVALID_ARGUMENT, version=abi/5.0.2)

Is this expected?

Also seems like the value of address is being taken as null.

[ricmoo]

That should definitely work. I use it all the time. Is the ens name configured? If an ens name doesn’t have a resolver or an addr entry it will return null.

The library probably should throw, in theses cases, a better error than allow the address coder to start the error chain...

[ricmoo]

The only places an ens name cannot be used is when it is required synchronously. Like in utils.computeContractAddress and simile utility function. Anything that is async supports it. :)

[zemse]

Thanks, I found out that I did not had the Networkish object passed for the particular provider that I had connected with the contract instance. So it was my mistake from my side. It is working now when done right.

Man, really, you have done such an amazing library! I'm so overwhelmed with this one. Actually I overrided the resolveName and lookupAddress methods to work with a different kind of registry (not similar to ENS). It's working smoothly even in this case!

The library probably should throw, in theses cases, a better error than allow the address coder to start the error chain...

That could be actually helpful. We can leave this issue open if in future this is desired to be addressed.

[ricmoo]

Yeah, a better error should only take like 4 minutes and I know exactly where to add it. :)

I just need to finish the new publish script to match the new build script and I’ll add this. Sure, open a new issue to track it. :)

Glad you enjoy the library! :)

[ricmoo]

This has been published in 5.0.15. Try it out and let me know if there are any issues.

Thanks! :)