-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed resolving ENS addresses used as from parameters (#3961).
- Loading branch information
Showing
2 changed files
with
19 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -817,7 +817,7 @@ export class AbstractProvider implements Provider { | |
[ "to", "from" ].forEach((key) => { | ||
if ((<any>request)[key] == null) { return; } | ||
|
||
const addr = resolveAddress((<any>request)[key]); | ||
const addr = resolveAddress((<any>request)[key], this); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ricmoo
Author
Member
|
||
if (isPromise(addr)) { | ||
promises.push((async function() { (<any>request)[key] = await addr; })()); | ||
} else { | ||
|
@ricmoo I haven't had a chance to check this particular flow yet, but would this get the correct
this
since it's in the forEach callback closure? Might need to bind thethis
from outside the closure.