Fix address coder to prepare non-hexdatastring addresses as hexdatast…

…ring (#1906).
ethers-io · Aug 24, 2021 · 017b1fe · 017b1fe
1 parent accb852
commit 017b1fe
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/abi/src.ts/coders/address.ts b/packages/abi/src.ts/coders/address.ts
@@ -17,7 +17,7 @@ export class AddressCoder extends Coder {
 
     encode(writer: Writer, value: string): number {
         try {
-            getAddress(value);
+            value = getAddress(value)
         } catch (error) {
             this._throwError(error.message, value);
         }

diff --git a/packages/tests/src.ts/test-contract-interface.ts b/packages/tests/src.ts/test-contract-interface.ts
@@ -659,3 +659,14 @@ describe('Test EIP-838 Error Codes', function() {
         }
     });
 });
+
+describe("Additional test cases", function() {
+    // See: #1906
+    it("allows addresses without the 0x", function() {
+        const iface = new ethers.utils.Interface([
+            "function test(address foo) view returns (bool)"
+        ]);
+        const tx = iface.encodeFunctionData("test", [ "c1912fee45d61c87cc5ea59dae31190fffff232d" ]);
+        console.log(tx);
+    });
+});