Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

ECIP-1015 GasReprice fork #59

Merged
merged 3 commits into from
Oct 15, 2016
Merged

ECIP-1015 GasReprice fork #59

merged 3 commits into from
Oct 15, 2016

Conversation

splix
Copy link
Contributor

@splix splix commented Oct 15, 2016

ECIP-1015 GasReprice

changes applied from EF Geth ethereum/go-ethereum@64af2aa

@splix
Copy link
Contributor Author

splix commented Oct 15, 2016

I don’t think it well tested though. all unit test from EF geth are passing, but we don’t have any integration tests for our chain yet (EF has one integration test, but it contains TheDAO Fork state changes, we can’ reuse it).

Someone should prepare json with test data (who wants?). See /tests/files/BlockchainTests/TestNetwork/bcEIP150Test.bak.json for example

@splix
Copy link
Contributor Author

splix commented Oct 15, 2016

As we follow Semantic Versioning, this release must be 3.0.0. Because we introduce incompatible changes (basically every new fork is a new MAJOR version)

@splix splix mentioned this pull request Oct 15, 2016
Closed
@splix
Copy link
Contributor Author

splix commented Oct 15, 2016 •
edited
Loading

@ericsomdahl @elaineo @mikeyb @whatisgravity @realcodywburns please review

@splix splix added this to the Gas Reprice Fork milestone Oct 15, 2016
@splix
Copy link
Contributor Author

splix commented Oct 15, 2016

@ericsomdahl feel free to merge PR if you'll approve these changes

@splix
Copy link
Contributor Author

splix commented Oct 15, 2016

@ericsomdahl good catch! fixed

@ericsomdahl
Copy link
Member

I agree with @splix regarding the testing, especially circling back and creating a proper full blockchain test. Given the urgency I think this must do for now

ericsomdahl
ericsomdahl approved these changes Oct 15, 2016
View reviewed changes
Copy link
Member

@ericsomdahl ericsomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericsomdahl ericsomdahl merged commit d76ad4e into develop Oct 15, 2016
@elaineo
Copy link
Member

elaineo commented Oct 16, 2016

Looks like it's already merged, but i can add testdata for this.

@splix splix deleted the ecip/1015 branch January 25, 2017 17:56
soc1c added a commit that referenced this pull request Jun 19, 2019
@soc1c
docs: update readme (#59)
8e44d65 
* docs: update readme

* Update README.md

* Update README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsomdahl ericsomdahl ericsomdahl approved these changes

Assignees

@ericsomdahl ericsomdahl

Labels
Priority: 1 Critical
Projects
None yet
Milestone
Gas Reprice Fork
Development

Successfully merging this pull request may close these issues.
3 participants
@splix @ericsomdahl @elaineo