-
Notifications
You must be signed in to change notification settings - Fork 299
Update package.json to include published files #67
Conversation
Hi @jwerle, I think I had a reason on adding the slash here. Can you please provide a list with the files added to a local package creation with and without the change? |
I'll make a reproduction case in a repository. In any case the file glob in
that array says match all .js files in the / directory which causes tools
like pkg who read that property to resolve incorrectly.
…On Fri, Aug 17, 2018, 05:22 Holger Drewes ***@***.***> wrote:
Hi @jwerle <https://github.com/jwerle>, I think I had a reason on adding
the slash here. Can you please provide a list with the files added to a
local package creation with and without the change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZSvQiX3ZrSsRAKbX1nzbX6bXNsFz83ks5uRotrgaJpZM4V9VcW>
.
|
@holgerd77 Please see https://github.com/jwerle/pkg-ethereumjs-wallet-reproduction which contains two branches, one to show a failed run of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, tested this locally with npm pack
and then having a look at the generated tarball, package content stays the same. Thanks for the PR!
List the files that will be published to npm in the package.json so tools like pkg can correctly resolve files that are listed there.
Running
pkg
with any module that requiresethereumjs-wallet
will result in the following error:Correcting
/*.js
to*.js
fixes this. 🙌