Setup typedoc and fix web3-provider-engine dependency

[alcuadrado]

This PR is a continuation of #98

[holgerd77]

Linting error. 😉

[alcuadrado]

Oops. Fixed them.

[alcuadrado]

Oh, I was running the wrong command. I didn't notice that. Thanks for fixing it

[alcuadrado]

Oh, I merged from master and never rechecked this. Will do it today.

…

On Wed, Apr 22, 2020 at 10:53 AM Holger Drewes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#112 (comment)> : > -Constructors: +> > > > > > > typedoc + +```js +const thirdparty = require('ethereumjs-wallet/thirdparty').default +``` + +ESM / TypeScript: + +```js +import thirdparty from 'ethereumjs-wallet/thirdparty' +``` There is still some kind of chaos here (and in the other API sections). Can you on fixing generally have some closer look at the import flavors and do a test, eventually also do a test install before? I was a bit playing around here and this doesn't seem to work as expected, maybe also have a look at this recently merged PR #109 <#109> along. Please test both the JS and TypeScript versions. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#112 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABLC4YQVZGBNIAPRQ22IUTRN3ZGLANCNFSM4MNVOEIQ> .

[kumavis]

thanks for this 🙌
looking forward to the next release

[alcuadrado]

I fixed a broken merge in the readme, regenerated the docs, and auto fix all styles.

[alcuadrado]

Also, note that you have to run npm install in the root of the project to be able to test the imports from the readme, and also replace the project name with ./dist.

[holgerd77]

Hi Patricio, you have got some broken local linting setup by some outdated config installation or old package-lock.json or the like? Can you fix this? This is pretty annoying. 🤨

Otherwise thanks for the fixes.

[alcuadrado]

Oh, that's probably the case. I deleted my node_modules, reinstalled everything, and could reproduce the error.

[holgerd77]

Got it, web3-provider-engine moved to devDependencies along the refactoring (I guess?), that's way require tests on a local test package always failed with
"Cannot find module 'web3-provider-engine/subproviders/hooked-wallet-ethtx'".

Can you eventually directly fix this here, move this to the dependencies but then also update the title from this issue so that this won't get lost?

Please wait with pushing again, I have a few more comments, will give another note on the last one.

[holgerd77]

Ok, that's it. All README import related, you likely just haven't take notice of #109 yet.

[alcuadrado]

Changed the imports, added the missing one, and fixed the package.json.

[holgerd77]

LGTM, thanks Patricio!