This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Upgrade to ethereumjs-config v2 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch from coveralls to codecov * fix lint errors
* add tsconfig to silence errors * remove custom types exclude (seems to be working without now) * lint
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=========================================
Coverage ? 97.10%
=========================================
Files ? 11
Lines ? 415
Branches ? 71
=========================================
Hits ? 403
Misses ? 3
Partials ? 9 Continue to review full report at Codecov.
|
holgerd77
approved these changes
Feb 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades this repository to ethereumjs-config v2, switches from coveralls to codecov, and fixes new lint errors. A few functions are moved up in their respective files to satisfy the
no-use-before-definerule.Closes #286.