Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: fix deposit address for sepolia and holesky #3882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Feb 24, 2025

This PR fixes the problem on Pectra's Holesky fork where the deposit address differs from the mainnet deposit address. This means that deposit logs for EIP-6110 are not picked up and will therefore yield the incorrect requestsHash.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (bd77a74) to head (832381d).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.87% <ø> (ø)
blockchain 85.69% <ø> (ø)
client 66.26% <ø> (-0.02%) ⬇️
common 90.73% <100.00%> (+0.01%) ⬆️
devp2p 76.27% <ø> (ø)
ethash 81.04% <ø> (ø)
evm 71.04% <ø> (ø)
genesis 99.84% <ø> (ø)
mpt 59.52% <ø> (ø)
rlp 69.70% <ø> (ø)
statemanager 70.47% <ø> (ø)
tx 80.96% <ø> (ø)
util 85.54% <ø> (ø)
vm 57.81% <ø> (ø)
wallet 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant