Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TransientStorage cleanups after Tx-level contract creation #3625

Merged
merged 4 commits into from
Sep 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/evm/src/evm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,10 @@ export class EVM implements EVMInterface {
}
}

if (message.depth === 0) {
this.postMessageCleanup()
}

return {
createdAddress: message.to,
execResult: result,
Expand Down
44 changes: 43 additions & 1 deletion packages/evm/test/transientStorage.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
import { createAddressFromString } from '@ethereumjs/util'
import {
createAddressFromString,
createZeroAddress,
equalsBytes,
hexToBytes,
setLengthLeft,
unpadBytes,
} from '@ethereumjs/util'
import { assert, describe, it } from 'vitest'

import { createEVM } from '../src/index.js'
import { TransientStorage } from '../src/transientStorage.js'

describe('Transient Storage', () => {
Expand Down Expand Up @@ -176,4 +184,38 @@ describe('Transient Storage', () => {
transientStorage.revert()
assert.deepEqual(transientStorage.get(address, key), value1)
})

it('should cleanup after a message create', async () => {
const evm = await createEVM()
// PUSH 1 PUSH 1 TSTORE
const code = hexToBytes('0x600160015D')
const keyBuf = setLengthLeft(new Uint8Array([1]), 32)
const result = await evm.runCall({
data: code,
gasLimit: BigInt(100_000),
})
const created = result.createdAddress!
const stored = evm.transientStorage.get(created, keyBuf)
assert.ok(
equalsBytes(unpadBytes(stored), new Uint8Array()),
'Transient storage has been cleared',
)
})

it('should cleanup after a message call', async () => {
const evm = await createEVM()
const contractAddress = createZeroAddress()
// PUSH 1 PUSH 1 TSTORE
const code = hexToBytes('0x600160015D')
await evm.stateManager.putCode(contractAddress, code)
const keyBuf = setLengthLeft(new Uint8Array([1]), 32)
await evm.runCall({
gasLimit: BigInt(100_000),
})
const stored = evm.transientStorage.get(contractAddress, keyBuf)
assert.ok(
equalsBytes(unpadBytes(stored), new Uint8Array()),
'Transient storage has been cleared',
)
})
})
Loading