Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statemanager: verify prestate accesses #3419

Closed

Conversation

gabrocheleau
Copy link
Contributor

This PR adds a verkle feature to verify that all the provided witness keys have been accessed during block execution. As per the spec, blocks that include extra witnesses are considered invalid and should be rejected.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (d24ca11) to head (e6cc146).
Report is 8 commits behind head on master.

❗ Current head e6cc146 differs from pull request most recent head 9bf6001. Consider uploading reports for the commit 9bf6001 to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
blockchain ?
common 94.29% <ø> (ø)
devp2p 81.85% <ø> (?)
statemanager ?
util ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau
Copy link
Contributor Author

After discussing this, it turns out that the postState exhaustiveness verification implicitly also acts as a satisfactory verification for the preState. Initially did not realize this was the case, but this means that we can now close this.

As for the other fixes and increased test coverage that were part of this PR, I will port them over to #3421

@holgerd77 holgerd77 deleted the statemanager/verkle-witness-no-extra-validation branch July 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant