Internalize crc
#3224
Internalize crc
#3224
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| } | ||
|
|
||
| const crc = (current: Uint8Array, previous?: number) => { | ||
| let crc = previous === 0 ? 0 : ~~previous! ^ -1 |
There was a problem hiding this comment.
The one thing I don't get is how this works if previous is undefined. The original version of this code just asserts it's not undefined but I'm not sure . Will work on some tests.
There was a problem hiding this comment.
~~undefined evaluates to 0 it seems. (! is a typescript operator (?))
There was a problem hiding this comment.
Could you link to the original version to see how it was being done.
There was a problem hiding this comment.
https://github.com/alexgorbatchev/crc/blob/master/src/calculators/crc32.ts It's this file, I copied basically unmodified other than for adding some type annotations that were missing.
.vscode/settings.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll.eslint": true | |||
| "source.fixAll.eslint": "explicit" | |||
There was a problem hiding this comment.
I have no idea. It just keeps getting auto updated in my local vscode settings. Lemme remove it. Didn't mean to commit but it just keeps showing up.
| } | ||
|
|
||
| const crc = (current: Uint8Array, previous?: number) => { | ||
| let crc = previous === 0 ? 0 : ~~previous! ^ -1 |
There was a problem hiding this comment.
~~undefined evaluates to 0 it seems. (! is a typescript operator (?))
There was a problem hiding this comment.
I am assuming this file is copied from the original package, I assume a license/source code pointer should be added?
There was a problem hiding this comment.
Ugh, sorry, I had that in here but somehow deleted it. Will re-add.
There was a problem hiding this comment.
Just saw this got merged wanted to add a super small nit: now the reference points to a GH file, but we should have used a permalink to that file instead (if it moves or changes it will not match what is there in the future))
| } | ||
|
|
||
| const crc = (current: Uint8Array, previous?: number) => { | ||
| let crc = previous === 0 ? 0 : ~~previous! ^ -1 |
There was a problem hiding this comment.
Could you link to the original version to see how it was being done.
This duplicates the
crc32code from thecrcdep into an internal utility.