Client: use same Cache Setup for normal and executeBlocks-triggered Execution #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the original options to be passed, adopt StateManager usage
… when run with --executeBlocks flag
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
acolytec3
previously requested changes
Sep 27, 2023
|
@acolytec3 thanks for the review 🙏, ok, have updated! |
acolytec3
reviewed
Sep 27, 2023
acolytec3
reviewed
Sep 27, 2023
acolytec3
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Left a couple of more comments on the docs. Feel free to take or leave them.
One more general question, do we ever actually copy the cache values over? I don't see that option anywhere in the code and our docs seem to indicate it's possible to do a copy where the state of the cache is actually preserved.
|
@acolytec3 ok, updated 🙂, ready for re-review! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the cache setup for the client for "normal" execution along sync or standalone and re-execution with the
--executeBlocksflag so that the StateManager and trie cache setups match the cache setup announced by client CLI, react on cache flag usage (especially trie cache) and generally allows for better cache behavior debugging (so that--executeBlocks"mimics" the normal execution behavior and not somewhat behaves differently).Implementation is done by getting generally more flexible (with additional
shallowCopy()method options), so that we but also users in general can choose if they want to have their shallow copy for rather short term or long term use.For trie I additionally generally generalized the options take in by using an options dict which replaces the plain keyPrefix parameter (still possible since not yet released). Then we can eventually add other options too there.
Open for review. 🙂