-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evm refactor (rebased on master a4c379a, 2022-06-13) #1955
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
vm: move eei/vmstate into new EEI dir
vm: fixes
vm: add comment
vm: fix gas refunds on CREATE opcdoes
vm/evm: fixup TransientStorage/EEI creation
db25167
to
8772284
Compare
Rebased this after a local test rebase, also did a backup of the branch state before the rebase. Will push soon afterwards with a VM api test fix. |
Will leave some generic TODOs here, absolutely don't need to be answered right now.
Ok, I will actually merge this in here so that we can proceed. This still need an in-depth after-merge review, but then we can go on and e.g. do the package separation. Review work can be done in separate PRs. Uff. No way back anyhow. 😜 😅 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Still needs an in-depth post-merge review.
Will merge by admin-merge for procedural reasons.
Rebased version and potential replacement for #1950
Rebase was a bit more hairy than expected 😋. 17 tests failing (VM -> API), most seem to be easy fixes (some base object not present, some EVM result not available "as is".
Nevertheless did not directly force-pushed on the original branch, but I would assume that it's worth to take this over here, fix the tests and then continue from here.