Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Execute on Breaking Release Notes #1690

Closed
wants to merge 8 commits into from
Closed

Common: Execute on Breaking Release Notes #1690

wants to merge 8 commits into from

Conversation

ScottyPoi
Copy link
Contributor

Fixes #1633

  1. Removed deprecated forCustomChain() constructor method
  2. Renamed all *BN methods to their non-BN names
  3. Update *BN method calls in the upstream monorepo libraries
  4. Removed chains/index.ts file and internalize the function _getInitializedChains() into the main index.ts file
  5. Removed genesisStates/index.ts
  6. Update method names in tests

@ScottyPoi
internalize _getInitializedChains and delete chains/index.ts
0854a61
@ScottyPoi
Rename common.hardforkBlockBN to common.hardforkBlock.
92272f4 
Remove depricated common.hardforkBlock method
Rename hardforkBlockBN() calls to hardforkBlock()
@ScottyPoi
Rename common.chainIdBN to common.chainId.
a36fb65 
Remove old common.chainId method
Rename all chainIdBN() calls to chainId()
@ScottyPoi
Rename common.networkIdBN to common.networkId
d7c76b7 
Remove old common.networkId method
Rename networkIdBN() calls to networkId()
@ScottyPoi
rename common.nextHardforkBlockBN to common.nextHardforkBlock
2d78006 
remove old common.nextHardforkBlock method
rename common netxtHardforkBlockBN() calls
@ScottyPoi
Remove deprecated Common.forCustomChain()
b655ce7 
Change all .forCustomChain() calls to Common.custom()
@ScottyPoi
Remove genesisStates/index.ts and genesisStates.spec.ts
e7b86a8
@ScottyPoi
Update definitions in common/docs/classes/default.md
a6b3fb9
@ScottyPoi ScottyPoi linked an issue Feb 4, 2022 that may be closed by this pull request
Common: Execute on all Deprecation Notes for Breaking Release #1633
Closed
@ScottyPoi ScottyPoi removed a link to an issue Feb 6, 2022
Common: Execute on all Deprecation Notes for Breaking Release #1633
Closed
@ScottyPoi ScottyPoi closed this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking package: block package: blockchain package: client package: common package: devp2p package: tx package: vm PR state: WIP type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ScottyPoi