Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Execute on Breaking Release Notes #1685

Closed
wants to merge 13 commits into from
Closed

Common: Execute on Breaking Release Notes #1685

wants to merge 13 commits into from

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented Feb 3, 2022 •
edited
Loading

Fixes #1633

  1. Removed deprecated forCustomChain() constructor method
  2. Renamed all *BN methods to their non-BN names
  3. Update *BN method calls in the upstream monorepo libraries
  4. Removed chains/index.ts file and internalize the function _getInitializedChains() into the main index.ts file
  5. Removed genesisStates/index.ts
  6. Update method names in tests

@ScottyPoi ScottyPoi linked an issue Feb 3, 2022 that may be closed by this pull request
Common: Execute on all Deprecation Notes for Breaking Release #1633
Closed
@ScottyPoi ScottyPoi changed the title PR State: Ready for Review - Fix for pr #1633 PR State: Ready for Review - Fix for issue #1633 Feb 3, 2022
@ScottyPoi ScottyPoi changed the title PR State: Ready for Review - Fix for issue #1633 PR State: WIP - Fix for issue #1633 Feb 3, 2022
@holgerd77 holgerd77 changed the title PR State: WIP - Fix for issue #1633 Common: Execute on Breaking Release Notes Feb 3, 2022
@ScottyPoi ScottyPoi removed a link to an issue Feb 4, 2022
Common: Execute on all Deprecation Notes for Breaking Release #1633
Closed
@ScottyPoi ScottyPoi closed this Feb 4, 2022
@holgerd77 holgerd77 deleted the Fix-for-PR-#1633 branch June 30, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking package: block package: blockchain package: client package: common package: devp2p package: tx package: vm PR state: WIP type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @holgerd77