Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo: esm support #1654

Closed
wants to merge 6 commits into from
Closed

monorepo: esm support #1654

wants to merge 6 commits into from

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Jan 20, 2022

This PR adds ./dist.esm builds for each package and fixes errors encountered.

WIP, some last few issues to fix, but this should be the majority of it.

@holgerd77
Copy link
Member

That's really great! 👍

Some note: if we want to integrate in the current minor releases, we should give this some really extensive testing - eventually even consider doing a round of rc releases (though I am not to keen on that one) - otherwise this is likely too risky.

So really do some test installations in various environments and see how things go.

@ryanio
Copy link
Contributor Author

ryanio commented Apr 6, 2022

going to pick this back up and get it updated to the latest master, so we can ship esm support

@holgerd77
Copy link
Member

going to pick this back up and get it updated to the latest master, so we can ship esm support

Ok, great, I guess it makes sense to then include this in the coming - originally - EIP-1153 focused release round mid next week or so?

Or can't you completely foresee how long this will take (or does this no make sense for other reasons?)?

@paulmillr
Copy link
Member

It would be great to understand if that's needed. If yes, we could make a round of js-eth-crypto releases as well

@ryanio
Copy link
Contributor Author

ryanio commented Jun 5, 2022

continued in #1936

@ryanio ryanio closed this Jun 5, 2022
@holgerd77 holgerd77 deleted the esm branch July 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants