Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types/bn.js from block,blockchain,trie,tx,vm packages #1136

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Mar 4, 2021

Fixes a TS compilation failure on install relating to ethereumjs-util 7.0.9.

PR:

  • removes @types/bn.js as a dependency everywhere
  • imports bn.js via ethereumjs-util everywhere (for clarity about its source)

Idea is:

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1136 (78161f2) into master (183b04a) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 81.82% <ø> (+0.21%) ⬆️
blockchain 84.19% <ø> (+0.06%) ⬆️
client 86.84% <ø> (-0.20%) ⬇️
common 87.24% <ø> (?)
devp2p 84.40% <ø> (+0.36%) ⬆️
ethash 82.08% <ø> (ø)
tx 85.67% <100.00%> (+0.16%) ⬆️
vm 82.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice simplification :)

@cgewecke cgewecke marked this pull request as ready for review March 5, 2021 03:06
@ryanio ryanio merged commit 5620105 into master Mar 5, 2021
@ryanio ryanio deleted the remove-types-bn.js branch March 5, 2021 03:07
@holgerd77
Copy link
Member

Ah, yeah, that's great. I wasn't aware that we have so many direct BN imports here. 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants