vm, client: made VM.runBlockchain() return value backwards-compatible…

… with Blockchain implemenations with an iterator void return value
ethereumjs · Jan 21, 2021 · 617d62f · 617d62f
1 parent 52a2a47
commit 617d62f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/client/lib/sync/fullsync.ts b/packages/client/lib/sync/fullsync.ts
@@ -76,7 +76,7 @@ export class FullSynchronizer extends Synchronizer {
       while (!newHead.equals(oldHead) && !this.stopSyncing) {
         oldHead = newHead
         this.vmPromise = this.vm.runBlockchain(this.vm.blockchain, 1)
-        const numExecuted = await this.vmPromise
+        const numExecuted = await this.vmPromise as number
         if (numExecuted === 0) {
           this.config.logger.warn(
             `No blocks executed past chain head hash=${short(

diff --git a/packages/vm/lib/index.ts b/packages/vm/lib/index.ts
@@ -272,7 +272,7 @@ export default class VM extends AsyncEventEmitter {
    *
    * @param blockchain -  An [@ethereumjs/blockchain](https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/blockchain) object to process
    */
-  async runBlockchain(blockchain?: Blockchain, maxBlocks?: number): Promise<number> {
+  async runBlockchain(blockchain?: Blockchain, maxBlocks?: number): Promise<void | number> {
     await this.init()
     return runBlockchain.bind(this)(blockchain, maxBlocks)
   }

diff --git a/packages/vm/lib/runBlockchain.ts b/packages/vm/lib/runBlockchain.ts
@@ -9,7 +9,7 @@ export default async function runBlockchain(
   this: VM,
   blockchain?: Blockchain,
   maxBlocks?: number
-): Promise<number> {
+): Promise<void | number> {
   let headBlock: Block
   let parentState: Buffer