Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECIP1087 [Draft]: A way to resolve the ECIP1061/ECIP1078/ECIP1086/EIP2200 testnet fiasco (rollback Mordor, leave Kotti) #295

Merged
merged 12 commits into from
Mar 3, 2020

Conversation

meowsbits
Copy link
Member

@meowsbits meowsbits commented Feb 20, 2020

Abstract

Don't touch Kotti; allow ECIP1061, ECIP1078, and ECIP1086 (EIP2200, EIP2200Disable) to continue as specified and implemented there.

Set Mordor ECIP1078 activation to 778507 (equivalent to ECIP1061), and rollback to 750000.

Rationale

Kotti is a PoA network, so it doesn't simulate (ie test) ETC mainnet in the first place (at least not well) since it uses different consensus rules. If it is a public simulation and test of ETC mainnet, it isn't a good one. So we can follow the logic of A: Testnets-as-service.

Mordor is a PoW network, so is is a pretty good simulator of ETC mainnet. We can follow the logic of B: Testnets-as-test, and not only resolve the issue of EIP2200 correction, but improve the network's simulation of mainnet activation for ECIP1061 and ECIP1078.


Rendered: https://github.com/meowsbits/ECIPs/blob/feat/ecip1087/_specs/ecip-1087.md

…tion

Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
… etc mainnet

Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
@soc1c
Copy link
Contributor

soc1c commented Feb 21, 2020

I agree with the rationale. Applying 1086 to Kotti makes a lot of sense.

To simplify the testnet reset on Mordor, I would propose to move both Aztlan and Phoenix to block 976_231. That way, we would invalidate the current chain anyways and force all clients to roll back.

@soc1c
Copy link
Contributor

soc1c commented Feb 21, 2020

I actually don't think we would need an ECIP for that. See #296 directly applying your suggestion.

@soc1c
Copy link
Contributor

soc1c commented Feb 21, 2020

would favor #297 instead and have a new specification for a "good" phoenix. see #298

@YazzyYaz
Copy link
Contributor

Should this be closed now?

@meowsbits
Copy link
Member Author

@YazzyYaz How about I'll edit to Withdrawn and we can merge for the sake for documentation (along w/ 1089).

Signed-off-by: meows <b5c6@protonmail.com>
@ghost
Copy link

ghost commented Feb 26, 2020

i approved "withdrawn" status

pls second approval and move to merge

@meowsbits
Copy link
Member Author

@ethereumclassic/ecip-editors please review for editorial righteousness for the doc-only merge

@ghost
Copy link

ghost commented Feb 27, 2020

@meowsbits License is clarified at the header, but I think if you add these details at the bottom, it's fine editorially:

Implementation

N/A

Copyright/Licensing

This work is licensed under Apache License, Version
2.0
.

per ethereumclassic#295 (comment)

Signed-off-by: meows <b5c6@protonmail.com>
@bobsummerwill
Copy link
Member

Is this obsoleted by Phoenix, @meowsbits?
Maybe just Close it now?

@meowsbits
Copy link
Member Author

meowsbits commented Feb 28, 2020

Yea it'll probably be practically obsoleted, but I think it should be merged because

  • https://github.com/ethereumclassic/ECIPs/pull/293/files was, which would by the same reasoning be considered obsoleted and this doc addresses a related issue
  • it has a strong rationale for differentiating Mordor and Kotti (as PoW and PoA) network utilities and management priorities (ie testnet as test vs. service). This argument/conceptual wrangling be come up again.
  • it has a number 1087 which would be left missing in the list which would bother me
  • the only cost i see is the additional weight of a piece of paper

Copy link
Member

@bobsummerwill bobsummerwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the historical record ...

@ghost
Copy link

ghost commented Feb 28, 2020

@bobsummerwill @meowsbits ...yes, I think it went thru a cycle and has to be merged as it was proposed, draft, and withdrawn...actually it should not go thru these cycles as a PR! ;)

@meowsbits
Copy link
Member Author

@ethereumclassic/ecip-editors beep boop Now we've established at least 3 times that this is for documentation only... please review for the format for the merge for the the PR-inbox sanity.

@BelfordZ BelfordZ merged commit a2e81c7 into ethereumclassic:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants