Add ChainID to Istanbul retesteth config #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running ChainID tests with aleth via retesteth.
I'm not sure about these points though:
Maybe it should better be hard-coded in retesteth (like genesis header is hard-coded)
Maybe it makes sense to add
networkIDfor completeness, too, but it doesn't affect anything at the moment.Maybe it makes sense to add it to other forks' configs, but it affects only Istanbul, because of CHAINID opcode tests.
(Note that it didn't affect geth, because it has
1there by default https://github.com/ethereum/go-ethereum/blob/3b6c9902f308ffc595912802644c5d21616e61f5/cmd/geth/retesteth.go#L310)