-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CHANGELOG.MD #571
Add a CHANGELOG.MD #571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 😀
Backfilled with the last two releases
aec3c7f
to
92e4c93
Compare
@@ -0,0 +1,76 @@ | |||
## Unreleased | |||
|
|||
No changes yet :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this line stands for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually this section will have the changes which are in develop but not part of any release. For now it's empty, this is just a placeholder so the empty section doesn't look weird, it will be removed once a PR is merged.
CHANGELOG.md
Outdated
|
||
### Potentially breaking changes | ||
|
||
- #547 requires your integration to understand the network `ByzantiumToConstantinopleAt5`, which is analogous to existing pseudo networks such as `FrontierToHomesteadAt5` and `EIP158ToByzantiumAt5`. It also changed the format of some blockchain tests, [keys of "0x" are now "0x00"](https://github.com/ethereum/tests/pull/547/files#diff-d31f2819c1febd4c8d673a15a8375af5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0x to 0x00 was done to the filler. It doesn't affect anything. Its just that 0x confuses me. No need to mention this change as it might confuse. Because real 0x requirement done to RLP tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Friendly ping :) |
@winsvega What is actually your policy for dealing with branches merged? I'm always having a first-time-impulse to press the "Delete branch" button above since we are doing this on EthereumJS and I find this a good practice to clean up the old branches. And then I hesitate on second thought and don't do because I wonder if you handle this otherwise? |
I delete old branches from time to time once there are too many. In rare cases I save some tests on a branch for a long time in case the work might be needed. Like tests for transaction from 0 address |
Backfilled with the last two releases.
Part of #531, opened by @holgerd77