Merge pull request #715 from ethereum/comment

add comment to double suicide test
ethereum · Jul 13, 2020 · 66a55cd · 66a55cd
2 parents feb0442 + b4c529c
commit 66a55cd
Show file tree

Hide file tree

Showing 8 changed files with 50 additions and 44 deletions.
diff --git a/BlockchainTests/GeneralStateTests/stSystemOperationsTest/doubleSelfdestructTest.json b/BlockchainTests/GeneralStateTests/stSystemOperationsTest/doubleSelfdestructTest.json
@@ -1,12 +1,12 @@
 {
     "doubleSelfdestructTest_d0g0v0_Istanbul" : {
         "_info" : {
-            "comment" : "The first test case required here https://github.com/ethereum/tests/issues/431#issue-306081539 .\nInvoked Solidity 0.4.21 with solc --bin-runtime --optimize\ncontract DoubleSelfdestructTest {\n  address constant B1 = 0x1;\n  address constant B2 = 0x2;\n  function remoteSelfdestruct() external {\n    selfdestruct(B2);\n  }\n  function() external payable {\n    this.remoteSelfdestruct();\n    selfdestruct(B1);\n  }\n}\n",
-            "filling-rpc-server" : "Geth-1.9.14-unstable-8cf83419-20200512",
-            "filling-tool-version" : "retesteth-0.0.3+commit.672a84dd.Linux.g++",
-            "lllcversion" : "Version: 0.5.14-develop.2019.11.27+commit.8f259595.Linux.g++",
+            "comment" : "The first test case required here https://github.com/ethereum/tests/issues/431#issue-306081539 .\nInvoked Solidity 0.4.21 with solc --bin-runtime --optimize\ncontract DoubleSelfdestructTest {\n  address constant B1 = 0x1;\n  address constant B2 = 0x2;\n  function remoteSelfdestruct() external {\n    selfdestruct(B2);\n  }\n  function() external payable {\n    this.remoteSelfdestruct();\n    selfdestruct(B1);\n  }\n}\nBecause gasprice is 0 and mining reward is 0, the mining account is created as empty in the post state. (imitating blockchain rules)\n",
+            "filling-rpc-server" : "evm version 1.9.15-unstable-365a7ec8-20200629",
+            "filling-tool-version" : "retesteth-0.0.6-profiling-berlin+commit.caf8b516.Linux.g++",
+            "lllcversion" : "Version: 0.5.14-develop.2020.6.22+commit.9189ad7a.Linux.g++",
             "source" : "src/GeneralStateTestsFiller/stSystemOperationsTest/doubleSelfdestructTestFiller.yml",
-            "sourceHash" : "07805baa8309d37bf675e5a3c277ae30cac0368aeb84e561e51235d0e0e88a26"
+            "sourceHash" : "ee28b9116fb59144fadf3e175db689e1931277a78490083eef66ffe06f5fcb61"
         },
         "genesisBlockHeader" : {
             "bloom" : "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
@@ -43,10 +43,10 @@
             }
         },
         "postState" : {
-            "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b" : {
+            "0x0000000000000000000000000000000000000002" : {
                 "code" : "0x",
-                "nonce" : "0x01",
-                "balance" : "0x0de0b6b3a7627960",
+                "nonce" : "0x00",
+                "balance" : "0x0de0b6b3a76586a0",
                 "storage" : {
                 }
             },
@@ -57,29 +57,29 @@
                 "storage" : {
                 }
             },
-            "0x0000000000000000000000000000000000000002" : {
+            "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b" : {
                 "code" : "0x",
-                "nonce" : "0x00",
-                "balance" : "0x0de0b6b3a76586a0",
+                "nonce" : "0x01",
+                "balance" : "0x0de0b6b3a7627960",
                 "storage" : {
                 }
             }
         },
         "network" : "Istanbul",
         "sealEngine" : "NoProof",
-        "lastblockhash" : "0x85342b8e532c318e685c198f5f90bb9276b754dd3f5b6a507f557af3710d72e2",
+        "lastblockhash" : "0x9825caf2d5f8ed2de6ed0937132ad9b5bb47cc86c13d780e9cbdf4746a4dc130",
         "genesisRLP" : "0xf901faf901f5a00000000000000000000000000000000000000000000000000000000000000000a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347942adc25665018aa1fe0e6bc666dac8fc2697ff9baa05269999e143540cd61e08a34f8eac69ea342f094869610e6e9f1733f8f1f25f6a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000808502540be400808000a00000000000000000000000000000000000000000000000000000000000000000880000000000000000c0c0",
         "blocks" : [
             {
-                "rlp" : "0xf90265f901f9a0ac8cb045ec68c97e3a819f2d2667e60df7985947229bacf5a8376259660f4275a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347942adc25665018aa1fe0e6bc666dac8fc2697ff9baa0a52c244a8aecb1581376120d6bbeee7d9653ed58a20e5c092c973fa66f09d572a01182d1b16e7090aa42a1e85ea80494dc8254eb57f5b3d30cf836396b64819a17a05fe2fc3aba9303eafe76d806185911c1fb7640bbcba0d40a4764738b2b601e49b90100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008302000001850254a0e6f882839c8203e800a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f866f8648080843b9aca0094095e7baea6a6c7c4c2dfeb977efac326af552d87830186a0801ca037de084a867928aff0d24ad4fc002b0cef4212d18e1916ca4c49ffd2ca498b10a06e5471d17e48ecf3a958278b05dc88582f43fc9caa28aa1788838bc1cb170ff3c0",
+                "rlp" : "0xf90265f901f9a0ac8cb045ec68c97e3a819f2d2667e60df7985947229bacf5a8376259660f4275a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347942adc25665018aa1fe0e6bc666dac8fc2697ff9baa0a52c244a8aecb1581376120d6bbeee7d9653ed58a20e5c092c973fa66f09d572a01182d1b16e7090aa42a1e85ea80494dc8254eb57f5b3d30cf836396b64819a17a05fe2fc3aba9303eafe76d806185911c1fb7640bbcba0d40a4764738b2b601e49b901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000018502540be40082839c8203e800a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f866f8648080843b9aca0094095e7baea6a6c7c4c2dfeb977efac326af552d87830186a0801ca037de084a867928aff0d24ad4fc002b0cef4212d18e1916ca4c49ffd2ca498b10a06e5471d17e48ecf3a958278b05dc88582f43fc9caa28aa1788838bc1cb170ff3c0",
                 "blockHeader" : {
                     "bloom" : "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
                     "coinbase" : "0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba",
                     "difficulty" : "0x020000",
                     "extraData" : "0x00",
-                    "gasLimit" : "0x0254a0e6f8",
+                    "gasLimit" : "0x02540be400",
                     "gasUsed" : "0x839c",
-                    "hash" : "0x85342b8e532c318e685c198f5f90bb9276b754dd3f5b6a507f557af3710d72e2",
+                    "hash" : "0x9825caf2d5f8ed2de6ed0937132ad9b5bb47cc86c13d780e9cbdf4746a4dc130",
                     "mixHash" : "0x0000000000000000000000000000000000000000000000000000000000000000",
                     "nonce" : "0x0000000000000000",
                     "number" : "0x01",
@@ -102,6 +102,8 @@
                         "r" : "0x37de084a867928aff0d24ad4fc002b0cef4212d18e1916ca4c49ffd2ca498b10",
                         "s" : "0x6e5471d17e48ecf3a958278b05dc88582f43fc9caa28aa1788838bc1cb170ff3"
                     }
+                ],
+                "uncleHeaders" : [
                 ]
             }
         ]

diff --git a/BlockchainTests/GeneralStateTests/stSystemOperationsTest/doubleSelfdestructTest2.json b/BlockchainTests/GeneralStateTests/stSystemOperationsTest/doubleSelfdestructTest2.json
@@ -1,12 +1,12 @@
 {
     "doubleSelfdestructTest2_d0g0v0_Istanbul" : {
         "_info" : {
-            "comment" : "The second test case requested here https://github.com/ethereum/tests/issues/431#issue-306081539 .\nInvoked Solidity 0.4.21 with solc --bin-runtime --optimize\ncontract DoubleSelfdestructTest2 {\n  address constant B = 0x3;\n  function remoteSelfdestruct() external {\n    selfdestruct(this);\n  }\n  function() external payable {\n    this.remoteSelfdestruct();\n    selfdestruct(B);\n  }\n}\nThe version of Solidity emits code that always enter OOG for Homestead and Frontier.  So no new accounts\nare created for Homestead and Frontier.  EIP158 changes the behavior of zero-amount transfer so that no new accounts are created.\nThis leaves EIP150 as a special case.\n",
-            "filling-rpc-server" : "Geth-1.9.14-unstable-8cf83419-20200512",
-            "filling-tool-version" : "retesteth-0.0.3+commit.672a84dd.Linux.g++",
-            "lllcversion" : "Version: 0.5.14-develop.2019.11.27+commit.8f259595.Linux.g++",
+            "comment" : "The second test case requested here https://github.com/ethereum/tests/issues/431#issue-306081539 .\nInvoked Solidity 0.4.21 with solc --bin-runtime --optimize\ncontract DoubleSelfdestructTest2 {\n  address constant B = 0x3;\n  function remoteSelfdestruct() external {\n    selfdestruct(this);\n  }\n  function() external payable {\n    this.remoteSelfdestruct();\n    selfdestruct(B);\n  }\n}\nThe version of Solidity emits code that always enter OOG for Homestead and Frontier.  So no new accounts\nare created for Homestead and Frontier.  EIP158 changes the behavior of zero-amount transfer so that no new accounts are created.\nThis leaves EIP150 as a special case.\nBecause gasprice is 0 and mining reward is 0, the mining account is created as empty in the post state. (imitating blockchain rules)\n",
+            "filling-rpc-server" : "evm version 1.9.15-unstable-365a7ec8-20200629",
+            "filling-tool-version" : "retesteth-0.0.6-profiling-berlin+commit.caf8b516.Linux.g++",
+            "lllcversion" : "Version: 0.5.14-develop.2020.6.22+commit.9189ad7a.Linux.g++",
             "source" : "src/GeneralStateTestsFiller/stSystemOperationsTest/doubleSelfdestructTest2Filler.yml",
-            "sourceHash" : "06869e0c371ec0500ca8a2c95190fa0e3df04822dd5a03d95535032a31d710fa"
+            "sourceHash" : "a167b40965fb06c8601b718fd23174e348fe9b292bea0d253cbaa494025a9fa1"
         },
         "genesisBlockHeader" : {
             "bloom" : "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
@@ -43,36 +43,36 @@
             }
         },
         "postState" : {
-            "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b" : {
+            "0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba" : {
                 "code" : "0x",
-                "nonce" : "0x01",
-                "balance" : "0x0de0b6b3a7627960",
+                "nonce" : "0x00",
+                "balance" : "0x1bc16d674ec80000",
                 "storage" : {
                 }
             },
-            "0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba" : {
+            "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b" : {
                 "code" : "0x",
-                "nonce" : "0x00",
-                "balance" : "0x1bc16d674ec80000",
+                "nonce" : "0x01",
+                "balance" : "0x0de0b6b3a7627960",
                 "storage" : {
                 }
             }
         },
         "network" : "Istanbul",
         "sealEngine" : "NoProof",
-        "lastblockhash" : "0x21502317e9862e6d2be4eb90f42e02b6bf365a501f55727493c114e53c9b5401",
+        "lastblockhash" : "0x828b367f83242db0fd2bb1144cdbf6ca5b2e3b7f61c5ddc5a95d28e38a2e038b",
         "genesisRLP" : "0xf901faf901f5a00000000000000000000000000000000000000000000000000000000000000000a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347942adc25665018aa1fe0e6bc666dac8fc2697ff9baa0dee120be57e9d149de0a77a155f90026af9ad09375930e9ea3224684f4483f0da056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000808502540be400808000a00000000000000000000000000000000000000000000000000000000000000000880000000000000000c0c0",
         "blocks" : [
             {
-                "rlp" : "0xf90265f901f9a0635f84a531c5fe9b4c337900c576e5bbd50859415e3e1880f42d3614ef1920d5a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347942adc25665018aa1fe0e6bc666dac8fc2697ff9baa01e102c142c6754143f31e227813b4c0c5b4115dc8985e9390fc0687f8d0e271aa01182d1b16e7090aa42a1e85ea80494dc8254eb57f5b3d30cf836396b64819a17a0d880bc9c09e30ed7e852fbf42a00703a8bdb4c98c75501f6e27a024e1cf6907db90100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008302000001850254a0e6f8823fdd8203e800a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f866f8648080843b9aca0094095e7baea6a6c7c4c2dfeb977efac326af552d87830186a0801ca037de084a867928aff0d24ad4fc002b0cef4212d18e1916ca4c49ffd2ca498b10a06e5471d17e48ecf3a958278b05dc88582f43fc9caa28aa1788838bc1cb170ff3c0",
+                "rlp" : "0xf90265f901f9a0635f84a531c5fe9b4c337900c576e5bbd50859415e3e1880f42d3614ef1920d5a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347942adc25665018aa1fe0e6bc666dac8fc2697ff9baa01e102c142c6754143f31e227813b4c0c5b4115dc8985e9390fc0687f8d0e271aa01182d1b16e7090aa42a1e85ea80494dc8254eb57f5b3d30cf836396b64819a17a0d880bc9c09e30ed7e852fbf42a00703a8bdb4c98c75501f6e27a024e1cf6907db901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000018502540be400823fdd8203e800a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f866f8648080843b9aca0094095e7baea6a6c7c4c2dfeb977efac326af552d87830186a0801ca037de084a867928aff0d24ad4fc002b0cef4212d18e1916ca4c49ffd2ca498b10a06e5471d17e48ecf3a958278b05dc88582f43fc9caa28aa1788838bc1cb170ff3c0",
                 "blockHeader" : {
                     "bloom" : "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
                     "coinbase" : "0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba",
                     "difficulty" : "0x020000",
                     "extraData" : "0x00",
-                    "gasLimit" : "0x0254a0e6f8",
+                    "gasLimit" : "0x02540be400",
                     "gasUsed" : "0x3fdd",
-                    "hash" : "0x21502317e9862e6d2be4eb90f42e02b6bf365a501f55727493c114e53c9b5401",
+                    "hash" : "0x828b367f83242db0fd2bb1144cdbf6ca5b2e3b7f61c5ddc5a95d28e38a2e038b",
                     "mixHash" : "0x0000000000000000000000000000000000000000000000000000000000000000",
                     "nonce" : "0x0000000000000000",
                     "number" : "0x01",
@@ -95,6 +95,8 @@
                         "r" : "0x37de084a867928aff0d24ad4fc002b0cef4212d18e1916ca4c49ffd2ca498b10",
                         "s" : "0x6e5471d17e48ecf3a958278b05dc88582f43fc9caa28aa1788838bc1cb170ff3"
                     }
+                ],
+                "uncleHeaders" : [
                 ]
             }
         ]