OSX: Fix readlink & ASTImportTest.sh issues. #9715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f4e20e to
2221db2
Compare
2221db2 to
5f7b4a2
Compare
chriseth
approved these changes
Sep 1, 2020
axic
reviewed
Sep 1, 2020
| REPO_ROOT=$(readlink -f "$(dirname "$0")"/..) | ||
| READLINK=readlink | ||
| if [[ "$OSTYPE" == "darwin"* ]]; then | ||
| READLINK=greadlink |
There was a problem hiding this comment.
What packages is this contained in?
There was a problem hiding this comment.
@axic greadlink is part of coreutils, installable via brew install coreutils.
There was a problem hiding this comment.
Can that be added to the dependencies list in the documentation? Or well, into the some developer docs which explains how to run all the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9711 and #9712. Also see #9710.
This is probably not the cleanest solution.
scripts/splitSources.py- system exception hook will print message and will result code3. This will be treated as a critical error byscripts/ASTImportTest.sh. If anUnicodeDecodeErrorexception occurs, the script will result code2,scripts/ASTImportTest.shwill ignore this, but will print stdout of the python script. The semantic of result code0and1are the same as before:0means that there was code extracted from a multi-source file and1means that the file was not a multi-source file. Also regarding splitSources.py can't handle invalid UTF-8 sequences #9710: splitting of multi-source files containing invalid utf-8 sequences is still not implemented.scripts/ASTImportTest.sh- use ofgreadlinkon osx ASTImportTests.sh broken on OS X (readlink: illegal option -- f) #9712. fix that it silently ignores errors by adding result code handling forscripts/splitSources.pyASTImportTest.sh silently ignores errors #9711.scripts/test_antlr_grammar.sh- use ofgreadlinkon osx.