Make command line tests to be able to run on unreleased version #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
previously approved these changes
Mar 25, 2021
|
The grep command is not working on mac os. |
3b90b6c to
30529fa
Compare
|
I rebased on top of #11162 and changed target branch here, so we get confirmation from CI that everything works as expected now. |
cameel
reviewed
Mar 25, 2021
30529fa to
2008bbd
Compare
cameel
reviewed
Mar 25, 2021
cameel
previously approved these changes
Mar 25, 2021
cameel
previously approved these changes
Mar 25, 2021
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
c3c5f65 to
8da630f
Compare
|
@cameel I clicked your suggestion and after that I did squash which dismissed your review |
cameel
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples from documentation are run on current build, and unreleased version is strictly less than currentVersion.
This searches for
pragma solidity ^$developmentVersionorpragma solidity >=$developmentVersionand replaces it withpragma solidity >0.0.1Depends on #11162 to be merged because OSX_cli will fail without it. Locally I worked with updates from that PR